Skip to content

chore: enforce figma links in relevant prs - #734

Open
ovitrif wants to merge 1 commit into
masterfrom
codex/731-figma-links
Open

chore: enforce figma links in relevant prs#734
ovitrif wants to merge 1 commit into
masterfrom
codex/731-figma-links

Conversation

@ovitrif

@ovitrif ovitrif commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Closes #731

Description

This PR:

  1. Adds a Design section to the PR template with Figma-link and explicit N/A guidance.
  2. Aligns agent authoring and review rules for missing screens-map entries and advisory link requests.

Linked Issues/Tasks

Design

N/A — no UI changes.

Preview

N/A — no user-visible changes.

QA Notes

Manual Tests

N/A

Automated Checks

  • Local verification: policy-matrix inspection and git diff --check passed.

@ovitrif ovitrif self-assigned this Sep 8, 2026
@ovitrif
ovitrif requested a review from jvsena42 September 8, 2026 21:35
@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

The PR appears safe to merge, with two non-blocking policy-completeness issues that should be addressed to make the guidance reliable.

Findings

  1. P2 Screens Map Is Undiscoverable
  2. P2 Release PRs Omit Design

Summary

  • Defines explicit values for changes without designs or user-visible UI.
  • Makes missing Figma links advisory rather than approval- or CI-blocking.
  • Leaves the screens-map location undiscoverable and the release PR generator outside the new policy.

Comment thread .agents/commands/pr.md

**Design:**
- Always include a `### Design` section.
- For user-visible UI changes with an existing design, link the relevant Figma frames, using the screens map as the starting point.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Screens Map Is Undiscoverable

The new guidance tells authors and agents to start with “the screens map,” but it provides no path or link, and the PR workflow only gathers the template, recent PRs, commits, and diff statistics. Authors therefore cannot reliably find existing Figma frames and may report uncertainty or no available design when a design exists. Please identify the map explicitly or add it to the workflow's gathered context. The same unclear reference also appears in .github/pull_request_template.md and AGENTS.md.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread AGENTS.md

- UI PRs with an existing design must link the relevant Figma frames under `### Design`, using the screens map as the starting point.
- UI PRs with no available design, including new features, must use `N/A — no design available.` under `### Design`.
- PRs without user-visible UI changes must use `N/A — no UI changes.` under `### Design`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Release PRs Omit Design

The new repository-wide policy requires non-UI PRs to include ### Design with N/A — no UI changes., but the existing release command generates version-bump PR bodies with Description and Screenshot / Video sections only. Release PRs will therefore bypass the newly documented requirement. Please update that generator as part of this policy rollout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: enforce figma links in relevant prs

1 participant