Repository navigation
Log syscall names in verbose output - #465
Closed
user-name-owen wants to merge 10 commits into
Closed
user-name-owen wants to merge 10 commits into
user-name-owen wants to merge 10 commits into
Conversation
jserv
requested changes
Oct 24, 2026
jserv
left a comment
Contributor
There was a problem hiding this comment.
Check https://github.com/sysprog21/elfuse/blob/main/CONTRIBUTING.md carefully and rework git commits including commit messages.
Contributor
You MUST run the code on real machines before submissions! |
Author
|
Thanks for the review. I'm closing this PR since I can't meet the project's requirement of running the code on real hardware. Thanks for the feedback and sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #452
With --verbose, the syscall entry log printed only the raw number. This
adds a name table built from the SYSCALL_TABLE_ENTRIES X-macro in a new
shared header (src/syscall/syscall_names.h), and the entry log now
prints name(nr) for every number in dispatch.tbl. Numbers outside the
table (or without a name) still print the raw number, as before.
The original hist_names[] in debug/syscall-hist.c is left untouched to
keep the change minimal; dedup can be a follow-up if preferred.
Note: I could not run the full build myself (the project targets macOS;
I work on Linux/WSL), so code-level review and CI are the verification
here.
Summary by cubic
Fixes #452: the
--verbosesyscall entry log now prints a readable syscall name alongside its number (e.g.openat(48)) instead of only the raw number. Syscalls outside thedispatch.tbltable still print the raw number as before.A new shared header
src/syscall/syscall_names.hbuilds the name table fromSYSCALL_TABLE_ENTRIES, so entries added todispatch.tblautomatically gain names. The full build was not run (the project targets macOS; development happened on Linux/WSL), so verification relies on code review and CI.Written for commit 7b4e312. Summary will update on new commits.