Skip to content

Log syscall names in verbose output - #465

Closed
user-name-owen wants to merge 10 commits into
sysprog21:mainfrom
user-name-owen:verbose-syscall-names
Closed

user-name-owen wants to merge 10 commits into
sysprog21:mainfrom
user-name-owen:verbose-syscall-names

Conversation

@user-name-owen

@user-name-owen user-name-owen commented Oct 24, 2026 •

Copy link
Copy Markdown

Fixes #452

With --verbose, the syscall entry log printed only the raw number. This
adds a name table built from the SYSCALL_TABLE_ENTRIES X-macro in a new
shared header (src/syscall/syscall_names.h), and the entry log now
prints name(nr) for every number in dispatch.tbl. Numbers outside the
table (or without a name) still print the raw number, as before.

The original hist_names[] in debug/syscall-hist.c is left untouched to
keep the change minimal; dedup can be a follow-up if preferred.

Note: I could not run the full build myself (the project targets macOS;
I work on Linux/WSL), so code-level review and CI are the verification
here.


Summary by cubic

Fixes #452: the --verbose syscall entry log now prints a readable syscall name alongside its number (e.g. openat(48)) instead of only the raw number. Syscalls outside the dispatch.tbl table still print the raw number as before.

A new shared header src/syscall/syscall_names.h builds the name table from SYSCALL_TABLE_ENTRIES, so entries added to dispatch.tbl automatically gain names. The full build was not run (the project targets macOS; development happened on Linux/WSL), so verification relies on code review and CI.

Written for commit 7b4e312. Summary will update on new commits.

View guided diff

@jserv jserv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check https://github.com/sysprog21/elfuse/blob/main/CONTRIBUTING.md carefully and rework git commits including commit messages.

@jserv

jserv commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Note: I could not run the full build myself (the project targets macOS; I work on Linux/WSL), so code-level review and CI are the verification here.

You MUST run the code on real machines before submissions!

@user-name-owen

Copy link
Copy Markdown
Author

Thanks for the review. I'm closing this PR since I can't meet the project's requirement of running the code on real hardware. Thanks for the feedback and sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--verbose prints syscall numbers without names

2 participants