Repository navigation
Umami: new service - #349
Conversation
|
Thanks for adding Umami, @noelob! I tested this branch locally and the core works well:
Before we can merge, please bring it in line with the service template and CONTRIBUTING.md:
Follow the template's sections and cover:
Root Please only add the Umami row. The PR also reformats the table's separator row and the Beszel Agent row, which is unrelated. PR description Please keep the template's Thanks again, looking forward to the update! |
12de9c4 to
95aab3d
Compare
95aab3d to
1a0cbe5
Compare
|
Thanks for the review @jackspiering , I think I've addressed all the feedback |
|
Thanks for the update, @noelob! This is much closer. I tested the new branch again (with Fixed since the last round: the port, the inline Serve configs with A few points are still open. Some are left from the last review, and some are new because the template changed after your first push (#351, #358, #363, #367). Sorry for the moving target.
All service READMEs moved to one fixed layout in #363. Please rewrite the file with the headings of the template README, in the same order and without other headings. Formbricks is a good example of a stack with a database. Your current text has almost everything; it mostly needs to move:
In the HTML example, remove the empty first line and close the tag with Pull request
Thanks again, this is nearly there! |
Move the .env comments to their own lines. Compose read an empty value with a comment on the same line as the comment text, so the database password, APP_SECRET, and TS_AUTHKEY were never empty. Make Compose stop when APP_SECRET or DB_PASSWORD is missing. Remove PUID, PGID, TZ, and DATABASE_TYPE from the application, because the image does not use them. Use the image tag that upstream uses. Rewrite the README with the standard headings.
|
@noelob, to save you another round I pushed the changes from my comment above as one commit to your branch (a0229e4). I also set the PR title and added the What the commit does:
Tested on a Tailnet node after the change:
|
Umami: new service
Description
Adds Umami, an open-source web analytics platform that respects user privacy. The stack has a private mode (Tailnet only) and a public mode that publishes the tracking script and the data collection endpoint through Funnel.
Related Issues
Verification
Tested locally with docker compose in both private and public mode
Checklist
Additional Context