Repository navigation
Ollama, Stirling-PDF, ArtistTrackarr, LubeLogger: remove settings that have no effect - #366
Merged
Merged
Conversation
…t have no effect - Ollama: remove the commented OLLAMA_API_KEY lines. The variable does not restrict access to the API. - Stirling-PDF: remove DOCKER_ENABLE_SECURITY=false. The image only acts on the value true, and it requires a login either way. - ArtistTrackarr: remove PUID and the misspelled PGI. The image always runs as user and group 10001. - LubeLogger: remove build: ., which has no Dockerfile and makes docker compose build fail.
crypt0rr
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Four stacks carry a setting that does nothing, and two of them suggest a behaviour that is not there. This pull request removes them. No stack behaves differently afterwards.
compose.yaml,.env): remove the commentedOLLAMA_API_KEYlines. Their comments say that the variable restricts access to the API. It does not: with the variable set in the container,GET /api/tagswithout a key still answered200.compose.yaml): removeDOCKER_ENABLE_SECURITY=false. The start script of the image only acts on the valuetrue, sofalseequals not setting it. The line reads as if it disables the login, but the current image creates the accountadmin/stirlingand requires a login either way.compose.yaml): removePUIDandPGI, a misspelling ofPGID. The image always runs as user and group10001and ignores both.compose.yaml): removebuild: .. The directory has no Dockerfile, sodocker compose buildanddocker compose up -d --buildfail.Related Issues
Verification
Each stack ran from a scratch copy with the Compose file from
mainand from this branch. A stand-in container replaced Tailscale, because the changes do not concern the network.mainDOCKER_ENABLE_SECURITYin the environment, login asadmin/stirlinganswers200200PUID=1000andPGI=1000in the environment, process runs as10001:10001, files in/dataowned by10001:10001docker compose buildfails:failed to read dockerfile: open Dockerfile: no such file or directoryNo services to build, the stack starts and becomes healthy/scripts/download-security-jar.shis the only file in the image that readsDOCKER_ENABLE_SECURITY, and it only tests fortrue.ollama/ollama:latest: withOLLAMA_API_KEYset in the container,GET /api/tagswithout a key answered200.docker compose config --quietin the four service directories: passed.git diff --check: passed.Checklist
Additional Context
mainstill has an "API Key (Optional)" section that describes the removed variable. All services: standardize the service READMEs #363 rewrites that README without it.