Skip to content

Ollama, Stirling-PDF, ArtistTrackarr, LubeLogger: remove settings that have no effect - #366

Merged
crypt0rr merged 2 commits into
mainfrom
compose-remove-dead-settings
Oct 8, 2026
Merged

crypt0rr merged 2 commits into
mainfrom
compose-remove-dead-settings

Conversation

@jackspiering

Copy link
Copy Markdown
Collaborator

Description

Four stacks carry a setting that does nothing, and two of them suggest a behaviour that is not there. This pull request removes them. No stack behaves differently afterwards.

  • Ollama (compose.yaml, .env): remove the commented OLLAMA_API_KEY lines. Their comments say that the variable restricts access to the API. It does not: with the variable set in the container, GET /api/tags without a key still answered 200.
  • Stirling-PDF (compose.yaml): remove DOCKER_ENABLE_SECURITY=false. The start script of the image only acts on the value true, so false equals not setting it. The line reads as if it disables the login, but the current image creates the account admin / stirling and requires a login either way.
  • ArtistTrackarr (compose.yaml): remove PUID and PGI, a misspelling of PGID. The image always runs as user and group 10001 and ignores both.
  • LubeLogger (compose.yaml): remove build: .. The directory has no Dockerfile, so docker compose build and docker compose up -d --build fail.

Related Issues

  • None.

Verification

Each stack ran from a scratch copy with the Compose file from main and from this branch. A stand-in container replaced Tailscale, because the changes do not concern the network.

Stack main This branch
Stirling-PDF Healthy, DOCKER_ENABLE_SECURITY in the environment, login as admin / stirling answers 200 Healthy, variable absent, same login answers 200
ArtistTrackarr Healthy, PUID=1000 and PGI=1000 in the environment, process runs as 10001:10001, files in /data owned by 10001:10001 Healthy, variables absent, same user and file owner
LubeLogger docker compose build fails: failed to read dockerfile: open Dockerfile: no such file or directory No services to build, the stack starts and becomes healthy
  • Stirling-PDF: /scripts/download-security-jar.sh is the only file in the image that reads DOCKER_ENABLE_SECURITY, and it only tests for true.
  • Ollama: the lines are comments, so the stack is unchanged. The check that the variable has no effect was done earlier with ollama/ollama:latest: with OLLAMA_API_KEY set in the container, GET /api/tags without a key answered 200.
  • docker compose config --quiet in the four service directories: passed.
  • git diff --check: passed.

Checklist

  • I have performed a self-review of my code and followed the templates structure.
  • I have added verification that the stack works as expected.
  • I have updated necessary documentation (e.g. frontpage README.md ).
  • I have selected the correct label(s) for this PR.

Additional Context

…t have no effect

- Ollama: remove the commented OLLAMA_API_KEY lines. The variable does not
  restrict access to the API.
- Stirling-PDF: remove DOCKER_ENABLE_SECURITY=false. The image only acts on
  the value true, and it requires a login either way.
- ArtistTrackarr: remove PUID and the misspelled PGI. The image always runs
  as user and group 10001.
- LubeLogger: remove build: ., which has no Dockerfile and makes
  docker compose build fail.
@jackspiering jackspiering added the bug Something isn't working label Oct 7, 2026
@jackspiering
jackspiering requested a review from crypt0rr October 7, 2026 18:41
@crypt0rr
crypt0rr merged commit 73bf1a4 into main Oct 8, 2026
1 check passed
@crypt0rr
crypt0rr deleted the compose-remove-dead-settings branch October 8, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants