Repository navigation
Copyparty: require your own password - #369
Open
jackspiering wants to merge 1 commit into
Open
jackspiering wants to merge 1 commit into
jackspiering wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Copyparty shipped the account
adminwith the passwordchangemeand read-write access to the shared host folder. It was the last working default credential in any compose or.envfile after #367 and #368.compose.yamlnow reads the password as${COPYPARTY_PASSWORD:?Set COPYPARTY_PASSWORD in .env}..envhas a# Required:comment and an emptyCOPYPARTY_PASSWORD=.compose.yamlor keptchangeme.Related Issues
Verification
docker compose config --quietpasses with a dummy value and stops withrequired variable COPYPARTY_PASSWORD is missing a valuewithout one. The rendered account line isadmin:<password>.[accounts]parser splits on the first colon, so the format is valid. The README asks for letters and digits only, whichopenssl rand -hex 32satisfies.rumdl check --config .markdownlint.yml .(0.2.78) andgit diff --checkare clean.Checklist
Additional Context
From an external review of the repository (section 3.1). The placeholder host path in the Copyparty stack is a separate item and is not changed here.