Repository navigation
libtailscale: mark handed-out fds close-on-exec - #71
Merged
Merged
Conversation
raggi
marked this pull request as ready for review
October 29, 2026 23:55
The listener and connection socketpairs and the fds received over SCM_RIGHTS were inheritable across fork/exec, so any process the host spawned kept a copy alive after the host closed its own fd. Closing a listener or connection then delivered no EOF until every such child had exited. Create every socketpair close-on-exec (SOCK_CLOEXEC on Linux, CloseOnExec under ForkLock.RLock elsewhere), and receive connection fds with MSG_CMSG_CLOEXEC on Linux or an immediate CloseOnExec on platforms without it. Fixes tailscale/tailscale#22054 Signed-off-by: James Tucker <james@tailscale.com> Change-Id: I5ae05cb18a7f5606f2492d9b2761770cf077f1a1
raggi
force-pushed
the
raggi/libtailscale-5ae05cb1
branch
from
October 30, 2026 00:00
6f6d65d to
1892c0b
Compare
bradfitz
reviewed
Oct 30, 2026
| // Copyright (c) Tailscale Inc & AUTHORS | ||
| // SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| //go:build !linux |
Member
There was a problem hiding this comment.
I thought a number of other unix OSes could do this too, but this is fine for now
bradfitz
approved these changes
Oct 30, 2026
cmol
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The listener and connection socketpairs and the fds received over
SCM_RIGHTS were inheritable across fork/exec, so any process the host
spawned kept a copy alive after the host closed its own fd. Closing a
listener or connection then delivered no EOF until every such child
had exited.
Create every socketpair close-on-exec (SOCK_CLOEXEC on Linux,
CloseOnExec under ForkLock.RLock elsewhere), and receive connection
fds with MSG_CMSG_CLOEXEC on Linux or an immediate CloseOnExec on
platforms without it.
Fixes tailscale/tailscale#22054
Signed-off-by: James Tucker james@tailscale.com