Repository navigation
fix(storage): accept verified native SQLite descriptor reuse - #113
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tangletools
approved these changes
Sep 29, 2026
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 7236d4ea
Blanket team auto-approval is intentional. The merge gates are CI and codex-p1.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-09-29T10:33:11Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A second in-process Setup save could fail with STORAGE_PATH_RACE: the SQLite Unix VFS reused an earlier verified descriptor to preserve POSIX locks, so it made no new open call. The Linux-only fallback now accepts reuse only from the maintained native cipher factory, with a live previously verified same-inode descriptor and an open database naming the validated file. Injected factories still fail closed. A WAL three-open regression was red before this fix and green after it; the compiled CLI now passes A→B→A at 120×40 and 80×24 with distinct credentials, save/reopen, encrypted reload, and authenticated preflight through final A. Full pnpm check passed on GTR. Loopback 503 means no live cloud task completed; package publication remains held pending protected live evidence.