style: widen the house-style rules to CLAUDE.md and .conventions - #176
Open
thecodedrift wants to merge 1 commit into
Open
style: widen the house-style rules to CLAUDE.md and .conventions#176thecodedrift wants to merge 1 commit into
thecodedrift wants to merge 1 commit into
Conversation
First slice of the broadening in #169. The three prose rules were scoped to READMEs only, because landing them repo-wide meant roughly 2300 findings at level: error. This adds the two smallest surfaces and fixes what they catch, so the slice is green on its own. 41 findings: 39 em dashes rewritten as a period, comma, colon, or parentheses per the rule's own message rather than swapped mechanically for one substitute, and two uses of "simply" where the sentence was describing a real distinction ("merely lives further down", "just out of date") rather than hedging. Fenced code blocks are untouched. These rules carry Vale's default scope, which does not read them, so the em dashes in the shell comments at CLAUDE.md:155 and STYLEGUIDE-CODE.md:222 are out of scope and stay. Remaining surfaces, in the order #169 proposes: TypeScript comments (Vale's comments-only tier), then the agent-facing recipe text, which is the largest. openspec/changes/archive/ gets a permanent exclusion rather than a slice. Refs #169 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017cEN93Acyp4zBwP3oDnyy1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (root → tip):
First slice of the broadening in #169, stacked on #168 because the rules it widens do not exist anywhere else yet.
The three prose rules currently match
**/README.mdonly. That was not a judgement about where the house style applies — it was that landing them repo-wide meant roughly 2300 findings atlevel: error, which is a remediation decision rather than a technical one. This slice takes the two smallest surfaces and fixes what they catch, so it is green on its own.What it catches, and what changed
41 findings across
CLAUDE.mdand.conventions/STYLEGUIDE-CODE.md:Nothing else in either file changed.
Scope decisions a reviewer should check
Fenced code blocks are untouched, deliberately. These rules carry Vale's default scope, which does not read them, so the em dashes in the shell comments at
CLAUDE.md:155andSTYLEGUIDE-CODE.md:222are genuinely out of scope. Widening torawto catch them would also mean the rules could no longer be suppressed per-case (see #167), and code comments in a fenced example are not the prose this rule is about.no-hedginggainsCLAUDE.md, which it did not have. It already covered.conventions/*.md, so this makes the pair consistent rather than adding a surface arbitrarily.Where the stack goes next
Per #169's ordering, and one PR per surface so each carries its own remediation and stays independently green:
CLAUDE.md+.conventions/(~47 findings).tsin its comments-only tier, so this touches comment prose and never codepackages/cli/src/agent/*.txt— the largest surface, and the most product-facing, since it is agent-facing recipe textopenspec/changes/archive/— a permanent exclusion rather than a slice. Rewriting an archived proposal would edit the record of what was proposed at the time, which feat: resolve the CLI invocation as a recipe variable #143's review thread already settledNo changeset, here or anywhere in this stack. Taskless rules live in
.taskless/and are not part of the published package, so none of this ships a release note.changeset.ymlwill warn; that is expected.One thing worth knowing
Measuring this slice on a machine with agent worktrees present produced 122 findings, of which 83 came from
worktrees/. That is #166, and its fix (#172) is not on this branch. The 41 above are the real in-scope count.Refs #169
🤖 Generated with Claude Code
https://claude.ai/code/session_017cEN93Acyp4zBwP3oDnyy1