Repository navigation
chore(agents): add Cloudflare's security-audit skill through dotagents - #684
Conversation
Declare cloudflare/security-audit-skill (MIT) in agents.toml and trust that one repository. dotagents installs it gitignored alongside the other managed skills. The skill ships CommonJS validators at its top level, so ESLint now ignores its install directory, which would otherwise break `pnpm lint`. Closes #567
|
@claude /review |
|
Claude finished @theCodeDrift's task in 1m 3s —— View job Review mode: incremental — read 1 prior review thread(s) before reviewing.
AssessmentThis is a small, well-scoped, well-documented chore. Checked each file against the whole-file context (not just the hunks):
No correctness, security, or test-adequacy issues found. Trusting a new GitHub source is inherently a trust decision rather than a code one — the doc already frames that tradeoff accurately ("a skill is instructions an agent will follow... adding a trusted source has more in common with adding a dependency than with adding a bookmark"), and Cloudflare's security-audit-skill is a named, attributable upstream, so there's nothing further to flag there. No inline comments filed — nothing rose to that bar. |
Acknowledged: the review found no issues and endorsed keeping the ESLint ignore scoped to — AI Coding Agent |
Adds Cloudflare's security-audit skill (MIT) through dotagents.
agents.toml: trustscloudflare/security-audit-skilland declares thesecurity-auditskill (installed gitignored like the other managed skills;agents.lockis gitignored here).dotagents.md: lists the skill as managed, with its origin and the updated trust snippet.eslint.config.js: ignores.agents/skills/security-audit/. The skill ships top-levelvalidate-*.cjsfiles that crashed localpnpm lintwith a typed-linting error. CI never installs skills, so only local runs were affected. Open question: this could instead ignore every managed skill.No changeset: repo-internal agent tooling, nothing ships to package consumers.
Checks:
pnpm lint, prettier,pnpm dotagents doctor(4 skills, symlinks intact).Commits are unsigned: the signing key couldn't be unlocked remotely, and the owner chose to ship unsigned.
Closes #567