Skip to content

Require 2FA before deleting services#120

Merged
arjunkomath merged 9 commits into
mainfrom
feat/require-2fa-service-delete
Jul 9, 2026
Merged

Require 2FA before deleting services#120
arjunkomath merged 9 commits into
mainfrom
feat/require-2fa-service-delete

Conversation

@techulus-agent

Copy link
Copy Markdown
Collaborator

Summary

  • Require server-side password + TOTP verification before service deletion when the current user has 2FA enabled.
  • Keep the existing service delete flow unchanged for users without 2FA.
  • Add conditional password/authenticator-code fields to the service delete dialog and keep the dialog open on verification errors.
  • Add focused helpers/tests for service-delete confirmation and 2FA code normalization.

Validation

  • ./node_modules/.bin/biome check --write on touched files
  • ./node_modules/.bin/vitest run tests/two-factor.test.ts tests/service-delete-confirmation.test.ts
  • ./node_modules/.bin/tsc --noEmit --pretty false

Note: the local toolchain still prints non-fatal mise warnings while trying to refresh pnpm metadata, but the checks completed successfully.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit a38ac10.

@arjunkomath arjunkomath marked this pull request as ready for review July 9, 2026 10:52
@arjunkomath arjunkomath enabled auto-merge July 9, 2026 13:23
@arjunkomath arjunkomath merged commit b5c2192 into main Jul 9, 2026
7 checks passed
@arjunkomath arjunkomath deleted the feat/require-2fa-service-delete branch July 9, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants