Skip to content

fix: avoid highlighting hyphenated shell arguments as flags #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xHeaven wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: avoid highlighting hyphenated shell arguments as flags #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25bc43a
fix: avoid highlighting hyphenated shell arguments as flags
xHeaven Aug 12, 2026
ee2cb3c
fix: update terminal flag expectation
xHeaven Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Languages/Bash/Patterns/BashFlagPattern.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,14 @@

#[PatternTest(input: 'ls -la', output: '-la')]
#[PatternTest(input: 'grep --color=auto', output: '--color')]
#[PatternTest(input: './tempest mcp:serve demo-server', output: null)]
final readonly class BashFlagPattern implements Pattern
{
use IsPattern;

public function getPattern(): string
{
return '(?<match>--?[a-zA-Z][\w-]*)';
return '(?<match>(?<![\w-])--?[a-zA-Z][\w-]*)';
}

public function getTokenType(): TokenTypeEnum
Expand Down
2 changes: 1 addition & 1 deletion tests/Languages/Terminal/TerminalLanguageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static function provide_highlight_cases(): iterable
$ mkdir build; cd build
TXT,
<<<'TXT'
<span class="hl-comment">$</span> <span class="hl-keyword">npx</span> husky<span class="hl-generic">-init</span> <span class="hl-operator">&amp;&amp;</span> <span class="hl-keyword">npm</span> install
<span class="hl-comment">$</span> <span class="hl-keyword">npx</span> husky-init <span class="hl-operator">&amp;&amp;</span> <span class="hl-keyword">npm</span> install
<span class="hl-comment">$</span> <span class="hl-keyword">echo</span> <span class="hl-value">&quot;hello&quot;</span> <span class="hl-operator">||</span> <span class="hl-keyword">echo</span> <span class="hl-value">&quot;fallback&quot;</span>
<span class="hl-comment">$</span> <span class="hl-keyword">mkdir</span> build<span class="hl-operator">;</span> <span class="hl-keyword">cd</span> build
TXT],
Expand Down
Loading