Forward published release events to temporalio/temporal - #308
Open
stpierre wants to merge 2 commits into
Open
Conversation
|
|
This will let us automatically bump patch releases of the API module in OSS.
stpierre
force-pushed
the
stpierre/trigger-oss-api-update-on-release
branch
from
August 26, 2026 15:28
8de8cca to
8ac11b6
Compare
stpierre
marked this pull request as ready for review
September 3, 2026 16:16
tdyas
reviewed
Sep 3, 2026
| # this job needs. api-go is public, so they do happen. | ||
| if: >- | ||
| (github.event_name == 'pull_request' && | ||
| github.event.pull_request.head.repo.full_name == github.repository) || |
Member
Author
There was a problem hiding this comment.
github.repository and github.event.pull_request.head.repo.full_name are both fully-qualified owner/repo already, so it does.
| (github.event_name == 'pull_request' && | ||
| github.event.pull_request.head.repo.full_name == github.repository) || | ||
| (github.event_name == 'release' && | ||
| !github.event.release.draft && |
There was a problem hiding this comment.
Can this (or should this) check the event type as published?
Member
Author
There was a problem hiding this comment.
It can, but published is already the only type that triggers this WF (line 16).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This adds a GH workflow that runs when a release is published that forwards the event to temporalio/temporal.
Why?
This will let us automatically bump patch releases of the API module in OSS.
How did you test it?
Pre-merge, the workflow cannot be tested due to GH permissions. Once merged, the workflow is self-testing on future changes.
Potential risks
None; if the job fails, the release is still published and updating the API module proceeds manually.