Adding field for gradual ramp requests - #854
Open
stuart-wells wants to merge 2 commits into
Open
Conversation
xwduan
reviewed
Aug 18, 2026
| bool promote_namespace = 7; | ||
| // Duration over which replication traffic should ramp to 100% for passive clusters added by | ||
| // this request. An unset or non-positive duration disables the ramp for this request. | ||
| google.protobuf.Duration replication_ramp_duration = 8; |
There was a problem hiding this comment.
Will it be better to put it inside NamespaceReplicationConfig?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Adding field for requesting a gradual ramp duration on a namespace.
Why?
Gradual ramp will allow a namespace that was just connected for replication to come up slowly and not overwhelm the connected passive cell. It is best to do this on a per-namespace basis instead of having a cell-wide policy.
Breaking changes
n/a
Server PR
n/a