Jeri/immutable releases - #105
Closed
jeri-temporal wants to merge 2 commits into
Closed
Conversation
* Use latest goreleaser * Run release workflow on every new tag * Keep release as draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same changes as in #104, just from an in-repo branch so the tests can run
What was changed
The current release workflow behavior runs goreleaser after a release has been published, but that's not permitted with immutable releases; all artifacts must be attached to the release by the time it is published. This change switches to running goreleaser on tag creation, and a successful run of the workflow will create a draft release ready for publishing or further editing.
Why?
Immutable releases are a requirement for adding new packages to
homebrew/core, and seem like they're generally a good idea anywayChecklist