Repository navigation
Adopt existing Temporal cloud Namespaces with the adopt policy - #66
Open
nmechack27 wants to merge 1 commit into
Open
nmechack27 wants to merge 1 commit into
nmechack27 wants to merge 1 commit into
Conversation
nmechack27
requested review from
jaypipes,
tomba7 and
zainawaisn
and removed request for
jaypipes
November 5, 2026 00:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds the
adoptadoption policy for Namespaces, so an existing Temporal Cloud Namespace can be brought under the TCO's management without recreating it. The user writes only the name and thecloud.temporal.io/adoption-policy: adoptannotation, and the operator fills in the spec from Temporal Cloud (similar to ACK'sadopt).Adoption(controller/namespace/adopt.go, called fromResourceSetLatestwhenstatus.idis empty): the Namespace is looked up by name.Schema(namespace.go+ regenerated CRD):spec,replicas, andretentionDaysare optional so a name-only CR is accepted; the admission policy in #64 requires them for everything butadopt. Addsstatus.source.Retain by default(deletionPolicy): adopted Namespaces without a deletion-policy annotation are kept on delete; an explicit annotation still wins.AdoptionPolicy:adoptis the only valid value for now;adopt-or-createcomes in a follow-up.Why?
Checklist
Closes
How was this tested:
Unit tests for now but once Tomba's #64 lands I will be able to test it e2e