External Storage Integration: Lazy resolving references, general refactoring - #3016
Open
cconstable wants to merge 1 commit into
Open
External Storage Integration: Lazy resolving references, general refactoring#3016cconstable wants to merge 1 commit into
cconstable wants to merge 1 commit into
Conversation
cconstable
force-pushed
the
extstore/foundation
branch
from
August 18, 2026 21:03
3fe47fb to
831c284
Compare
cconstable
commented
Aug 19, 2026
| private boolean allowActivityHeartbeatDuringShutdown; | ||
| private String workerControlTaskQueue; | ||
| private PreferredVersionProvider preferredVersionProvider; | ||
| private @Nullable ExternalStorage externalStorage; |
Contributor
Author
There was a problem hiding this comment.
This doesn't have any callers in this PR but three of the PRs that build off this will use it. Included it here since those PRs are being up together.
…former to ExternalStorage, create a lazy extstore resolving data converter.
cconstable
force-pushed
the
extstore/foundation
branch
from
August 19, 2026 17:40
831c284 to
460bfbf
Compare
cconstable
changed the title
cconstable
changed the title
cconstable
changed the title
cconstable
marked this pull request as ready for review
August 19, 2026 18:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
ExternalStorageMessageTransformertoExternalStorage.ExternalStorageResolvingDataConverter, that does the external storage work and delegates to the existing data converter for everything else.fromPayload). We don't eagerly load them.Why?
These changes support the following PRs:
Checklist