Skip to content

refactor(client): handle a failed status in the retry loop without try - #849

Open
xepozz wants to merge 1 commit into
masterfrom
refactor/base-client-retry-without-try
Open

xepozz wants to merge 1 commit into
masterfrom
refactor/base-client-retry-without-try

Conversation

@xepozz

@xepozz xepozz commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

What was changed

Why?

The only ServiceClientException in call() was thrown and caught in the same block. A custom stub that throws this exception is no longer retried.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

The only ServiceClientException in call() was thrown and caught in the same block.
A custom stub that throws this exception is no longer retried.
@xepozz
xepozz requested review from a team, roxblnfk and wolfy-j as code owners November 6, 2026 17:37
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-06T17:37:19.458453Z
We couldn’t complete this review. Comment @codex review to try again.
b6d1e5d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant