Skip to content

test(itest): capture drainage state on integration-test failure [DO N… - #552

Open
tomba7 wants to merge 2 commits into
mainfrom
tomba/triage-542-integ-intermittent-failures
Open

test(itest): capture drainage state on integration-test failure [DO N…#552
tomba7 wants to merge 2 commits into
mainfrom
tomba/triage-542-integ-intermittent-failures

Conversation

@tomba7

@tomba7 tomba7 commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Note: This is diagnostic code for testing the CI pipeline and will not be merged

Triage instrumentation for #542. The failure only says "timeout waiting for
deployment", which does not say why the controller declined to create the
version. This logs the state to check whether a version stuck in Draining ever recovers

  • logRolloutDiagnostics: Temporal's version list with drainage status, the
    controller's current/target, each deprecated version's EligibleForDeletion
    bit and the ineligible count against the cap.
  • postMortemDrainageWatch: after a failure, polls for up to 5 minutes and logs
    drainage transitions plus whether the Deployment eventually appears.

Local finding so far: under fsync throttling, one version latches in Draining
with zero transitions in 5 minutes while its siblings drain normally. When the
latched version is the 0 replica one, the ineligible count hits the cap and
the controller silently refuses the rollout which is what is seen on the CI

@tomba7
tomba7 requested review from a team, eniko-dif and jlegrone as code owners August 27, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant