Repository navigation
Color runs by regex (Experiment Name): match experiment aliases first - #7171
Merged
Merged
Conversation
cdavalos7
self-requested a review
November 10, 2026 17:50
cdavalos7
reviewed
Nov 10, 2026
cdavalos7
reviewed
Nov 10, 2026
cdavalos7
reviewed
Nov 10, 2026
cdavalos7
left a comment
Contributor
There was a problem hiding this comment.
Really appreciate you contributing this. A couple of small suggestions and it's good to go.
Contributor
Author
|
Thanks for the review and for smoke-testing it! -> Renamed the label to "Experiment Alias / Name" (dialog option, group menu, test assertion). |
despoisj
force-pushed
the
color-by-experiment-alias
branch
from
November 19, 2026 09:16
56a045b to
46ccfac
Compare
… take(1) in onSave)
cdavalos7
approved these changes
Nov 19, 2026
cdavalos7
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for your contribution Julien
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
"Color runs by regex" with Regex type = Experiment Name (
GroupByKey.REGEX_BY_EXP) currently only matches the regex againstexperiment.name. In the compare view, users assign aliases in the URL (/compare/alias1:eid1,alias2:eid2), and these aliases are what they see and reason about, while experiment names are often auto-generated (e.g. launch timestamps or IDs). As a result, it is not possible to color by the aliases — for example to give a run and its resumed continuation (heads16,heads16_resumed) the same color.The original feature request (internal b/216856119) asked for matching against the experiment name or its alias; only the name was implemented.
Technical description of changes
groupRuns(runs/store/utils.ts): forREGEX_BY_EXP, match the regex against the experiment alias first when one is defined, and fall back to the experiment name otherwise. Also no longer throws if an experiment name is missing for a run.getExperimentIdToAliasTextMap(app_routing/store/app_routing_selectors.ts): experiment id -> alias text, derived fromgetExperimentIdToExperimentAliasMap.expAliasByExpIdthroughfetchRunsSucceeded,runGroupByChanged, the runs reducer, the runs effects, the regex edit dialog (including the color group preview) and the group menu button.No new
GroupByKey, no URL/state format change, no UI change. Behavior only changes in the compare view, when the regex matches an alias (the alias' capture groups then define the color group). Regexes that match only experiment names keep working through the fallback.Screenshots of UI changes (or N/A)
Compare view with 5 experiments aliased
Baseline,Heads16,Heads16_8x8,Emb512,Emb512_8x8(experiment names are timestamps), Regex type = Experiment Name:(Heads|Emb|Baseline): "There are no runs matching the regex".Baseline,Heads(Heads16 + Heads16_8x8),Emb(Emb512 + Emb512_8x8).^20261015(matches experiment names only): grouped by name as before (fallback).(train|test): unchanged.Detailed steps to verify changes work correctly (as executed by you)
utils_test.ts: alias takes precedence over name; falls back to name when the alias does not match; works with aliases only.app_routing_selectors_test.ts:getExperimentIdToAliasTextMapfor compare and non-compare routes.runs_effects_test.ts:fetchRunsSucceededincludes aliases.regex_edit_dialog_test.ts:runGroupByChangedincludes aliases.Alternate designs / implementations considered (or N/A)
GroupByKey, serialization) for little benefit, since aliases are only defined in the compare view and falling back to the name keeps existing regexes working.