Skip to content

fix(trino): resolve the mapped host port in get_connection_url() #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rusackas wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix(trino): resolve the mapped host port in get_connection_url() #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/testcontainers/community/trino/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def __init__(
)

def get_connection_url(self):
return f"trino://{self.user}@{self.get_container_host_ip()}:{self.port}"
return f"trino://{self.user}@{self.get_container_host_ip()}:{self.get_exposed_port(self.port)}"

def _configure(self):
pass
10 changes: 10 additions & 0 deletions tests/community/trino/test_trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import sqlalchemy
from trino.dbapi import connect

from testcontainers.community.trino import TrinoContainer
Expand All @@ -16,3 +17,12 @@ def test_docker_run_trino():
rows = cur.fetchall()
assert rows[0][0] == "451"
conn.close()


def test_get_connection_url():
container = TrinoContainer("trinodb/trino:451")
with container as trino:
engine = sqlalchemy.create_engine(trino.get_connection_url())
with engine.connect() as connection:
result = connection.execute(sqlalchemy.text("SELECT version()"))
assert result.fetchone()[0] == "451"