fix: preserve generic query element types in render result - #1469
Open
korkt-kim wants to merge 1 commit into
Open
fix: preserve generic query element types in render result#1469korkt-kim wants to merge 1 commit into
korkt-kim wants to merge 1 commit into
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 15b2ca2:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Preserve generic element types for the built-in queries returned by
renderandpure.render.Why:
RenderResultcurrently wraps each query withBoundFunction<Q[P]>, which loses the generic signatures provided by DOM Testing Library'sBoundFunctions<Q>.As a result, calls such as the following do not type-check as expected:
How:
Use
BoundFunctions<Q>as the source for each mapped query property.I kept the mapped property shape instead of intersecting with
BoundFunctions<Q>directly because the direct intersection exposes built-in queries as methods and triggers@typescript-eslint/unbound-methodfor existing destructured queries.Type tests were added for single- and multiple-element query variants.
Checklist:
docs site — N/A