make preg_replace() use generics#705
Open
alexchexes wants to merge 1 commit into
Open
Conversation
Collaborator
|
I wonder how this interacts with https://github.com/thecodingmachine/phpstan-safe-rule which IIRC does the same thing and more 🤔 |
It's a pain to cast the result of `\Safe\preg_replace()` to `string` every time. This PR makes the `preg_replace` return type conditional on the `$subject` parameter type, so if you pass a string, the return type is also `string`.
Author
|
@shish Some users intentionally do not use This doesn't conflict with it, PHPStan will keep using the rule's dynamic return type extension. This PR just makes the base safe PHPDoc more accurate for tools/users that rely on the package types directly. Please clarify if anything else is needed on my end for this PR to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a pain to cast the result of
\Safe\preg_replace()tostringevery time. This PR makes thepreg_replacereturn type conditional on the$subjectparameter type, so if you pass a string, the return type is alsostring.