Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169
With
withSymlinks({ resolvePaths: false }),isRecursivetreated one symlink target as inside another when its path merely started with the other's as a string, so a link to/x/shared-otherinside a link to/x/sharedwas skipped as recursive. It now compares whole path segments (isInside), after normalizing the target, since a customfscan return/on Windows. This keeps the existing rule that equal, ancestor and descendant targets count as recursive; only siblings whose names share a prefix change.Test: a
symlinks.test.tscase withroot/src -> sharedandshared/alias -> shared-other, for bothsyncandwithPromise. It fails without the change.On
master(790c182), 19 tests already fail without this change, and the same 19 fail with it. Applied onv6.5.0, all 107 pass.tsc --noEmit,npm run buildand Prettier pass on the branch. #162 moves these tests offmock-fs; if it lands first, I'll move this case to its fixtures.