Skip to content

fix Victron Orion TR device description - #713

Merged
DigiH merged 1 commit into
theengs:developmentfrom
benderl:victron-oriontr
Sep 4, 2026
Merged

fix Victron Orion TR device description#713
DigiH merged 1 commit into
theengs:developmentfrom
benderl:victron-oriontr

Conversation

@benderl

@benderl benderl commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description:

This PR fixes the device description of the Victron Orion TR, introduced in #708 .

  • Remove data points "current_in" and "current_out". This are leftovers from copy/paste of Orion-XS definition.
  • Added data point "off_reason".
  • Fixed condition and unsigned format of "volt_in".
  • Adjusted test case.
  • Cleanup doc file.

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@DigiH

DigiH commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Thanks

@DigiH
DigiH merged commit 2d4f02d into theengs:development Sep 4, 2026
8 checks passed
@benderl
benderl deleted the victron-oriontr branch September 4, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants