fix Victron SBS device description - #714
Merged
Merged
Conversation
Contributor
|
@benderl AFAIK the Smart Battery Sense really only has the voltage and temperature properties, so only these should be listed in the documentation. |
Contributor
Author
|
Should I add another doc file for my battery monitor "BMV-712"? |
Contributor
|
I already submitted that with my previous commit https://github.com/theengs/decoder/blob/development/docs/devices/Victron_BM.md but just realised that it should have an all caps name to be consistent with the other Victron docs ;) - Done https://github.com/theengs/decoder/blob/development/docs/devices/VICTRON_BM.md |
Contributor
Author
|
Ok, removed the doc change. |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes some issues in the device description of module Victron SBS
Checklist: