Skip to content

fix Victron SBS device description - #714

Merged
DigiH merged 1 commit into
theengs:developmentfrom
benderl:victron-sbs
Sep 4, 2026
Merged

fix Victron SBS device description#714
DigiH merged 1 commit into
theengs:developmentfrom
benderl:victron-sbs

Conversation

@benderl

@benderl benderl commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description:

This PR fixes some issues in the device description of module Victron SBS

  • fix condition of "consumed_ah" and "soc" to match the official docs
  • modify decoder of "alarm_reason" to correct word order and unsigned values
  • update doc file

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@DigiH

DigiH commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@benderl AFAIK the Smart Battery Sense really only has the voltage and temperature properties, so only these should be listed in the documentation.

@benderl

benderl commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Should I add another doc file for my battery monitor "BMV-712"?

@DigiH

DigiH commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

I already submitted that with my previous commit

https://github.com/theengs/decoder/blob/development/docs/devices/Victron_BM.md

but just realised that it should have an all caps name to be consistent with the other Victron docs ;) - Done

https://github.com/theengs/decoder/blob/development/docs/devices/VICTRON_BM.md

@benderl

benderl commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Ok, removed the doc change.

@DigiH

DigiH commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Thanks

@DigiH
DigiH merged commit 280c6fa into theengs:development Sep 4, 2026
8 checks passed
@benderl
benderl deleted the victron-sbs branch September 4, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants