Skip to content

Check target.Debug is not nil before we access it - #3596

Merged
peterebden merged 1 commit into
thought-machine:masterfrom
peterebden:check-debug-nil
Sep 8, 2026
Merged

Check target.Debug is not nil before we access it#3596
peterebden merged 1 commit into
thought-machine:masterfrom
peterebden:check-debug-nil

Conversation

@peterebden

Copy link
Copy Markdown
Collaborator

Got a report of this line panicking; surely nothing has validated that the .Debug attribute is set on the target before it tries to dereference it.

@peterebden

Copy link
Copy Markdown
Collaborator Author

Right so the main way of getting there is if you do plz debug -c opt //some:test or something to that effect. I suppose the build def in question does not apply the debug info if it's not in a debug config.

@peterebden
peterebden merged commit 26648df into thought-machine:master Sep 8, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants