Skip to content

Point agent instructions at the SDK development specification - #98

Open
brionmario wants to merge 1 commit into
thunder-id:mainfrom
brionmario:sdk-feature-parity-check
Open

Point agent instructions at the SDK development specification#98
brionmario wants to merge 1 commit into
thunder-id:mainfrom
brionmario:sdk-feature-parity-check

Conversation

@brionmario

@brionmario brionmario commented Sep 11, 2026

Copy link
Copy Markdown
Member

Purpose

The ThunderID SDK development specification defines the contract every SDK implements: layering, operational modes, configuration keys, client surface, error model, security floor, platform packaging, testing, and the cross-SDK parity rules. It lives in the product repository, along with the threat model behind its security floor and an agent skill that loads both and drives the work.

Nothing in this repository points at it, so a contributor or an agent working here has no way to find the contract this SDK is meant to implement. This adds that pointer to AGENTS.md, which CLAUDE.md already includes.

Approach

A link, not a copy. The specification governs all four SDK repositories, so duplicating it here would give it four places to drift. The section names the three documents and says when to read them:

  • The specification, for the contract this SDK implements.
  • The threat model, for the security posture the floor comes from.
  • The sdk-development skill, which loads both and drives the work from locating the SDK checkouts through validation to raising the linked pull requests.

It closes with the rule that matters most day to day: a capability landing here usually needs to land in the sibling SDKs too, and the pull request answers that question either way.

The same section, worded identically, goes into all four SDK repositories. The links resolve once thunder-id/thunderid#5367 merges, so that PR should land first.

Related Issues

Related PRs

SDK parity

The same change is raised in every SDK repository:

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
    • This PR is the documentation change.
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

Signed-off-by: Brion <info@brionmario.com>
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b86cd7e2-c502-4141-b4ca-0194d5f6de2c


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant