Skip to content

Rename a device by clicking its name - #10

Merged
scott-tp merged 2 commits into
masterfrom
feature/device-friendly-name
Nov 17, 2026
Merged

scott-tp merged 2 commits into
masterfrom
feature/device-friendly-name

Conversation

@scott-tp

@scott-tp scott-tp commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Rename, Save, and Cancel crowded the card title and were easy to miss. Pull request Let users rename a device already on the dashboard #9 already shipped the rename endpoint and the 60-character limit.
  • Click the name and leave the field to save. Escape, a blank field, or an unchanged field keeps the stored name. A failed save puts the old name back and shows the error in the same danger red as Remove.
  • The accessible name says Rename plus the device name. The error is an alert. Escape or Enter returns focus to the title. Clicking outside does not move focus, so that click still lands.
  • The name shrinks beside the header buttons, so Open WebUI and Cloud's Open Assistant in that same slot stay visible. The card does not rebuild, so the preview stays.

Test plan

  • ./venv/bin/pytest -q tests/test_api_connections.py tests/test_remove_device_ui.py (42 passed)
  • ./dev-scripts/check-python (71 passed)
  • ./dev-scripts/check-javascript
  • Click the name, change it, click outside. The heading updates and the preview stays.
  • Escape, and a blank field, leave the stored name in place.
  • Escape or Enter returns focus to the title. Clicking outside does not.
    Review on CodeApprove

Save and Cancel made the title easy to miss, and the name has to give up space when another button sits in the header. Leave the field to save, and keep that name from covering the buttons.
The title only showed the device name, so a failed save was easy to miss. The accessible name says Rename, the error uses the Remove button's danger color, and Escape or Enter returns focus to the title.
@scott-tp
scott-tp merged commit c3d1e42 into master Nov 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant