Repository navigation
Rename a device by clicking its name - #10
Merged
Merged
Conversation
Save and Cancel made the title easy to miss, and the name has to give up space when another button sits in the header. Leave the field to save, and keep that name from covering the buttons.
The title only showed the device name, so a failed save was easy to miss. The accessible name says Rename, the error uses the Remove button's danger color, and Escape or Enter returns focus to the title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
./venv/bin/pytest -q tests/test_api_connections.py tests/test_remove_device_ui.py(42 passed)./dev-scripts/check-python(71 passed)./dev-scripts/check-javascript