Repository navigation
Stop storing previews and add Replace API key - #8
Merged
Merged
Conversation
Match the privacy promise: live screenshots stay in the browser Cache Storage, unused schema columns drop on init, and device cards can replace an Automation API key without removing the device.
Author display:flex on .preview-placeholder overrode the hidden attribute, so a successful JPEG stayed covered by the loading gradient.
Drop the shimmer and monitor icon so empty preview states match the dashboard subtitle style; Connected already implies the computer side.
Match No signal / Offline as large centered labels; drop the corner badge so offline-with-cache uses the same treatment.
Also align empty Offline with the dark No signal well, yellow-caution non-live preview status copy, and Offline/No signal checked phrasing.
Place the action beside Remove device and reuse the remove-modal layout with a password field, hint, and Save/Cancel.
Drop the remove re-add disclaimer, split replace-key instructions onto two spaced lines, and give modal instructions consistent spacing.
Drop the smaller custom instruction block; keep normal subtitle font with a looser line-height for the replace-key line break.
Keep RequestException and non-signal ValueErrors off the no-signal path, drop the sticky offline flag, and document Cache Storage / SQLite limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PUT /api/devices/<id>/api-keywith a Replace API key confirm modal (not inline form) updates the encrypted Automation key without removing the device.Test plan
pytest -qgreen (66 passed locally)data/screenshots/emptied / unusedwindow.tinypilotPreviewCache.clearPreviewCache()