Repository navigation
Ensure FAT file timestamps match when files were written - #32
Merged
Merged
Conversation
An off-by-one error in the bit shifts and seconds mask caused timestamps to be incorrectly packed into the FAT timestamp structure. This caused files to report incorrect modification dates and times.
davecheney
force-pushed
the
dfc/fatfs-timestamps
branch
from
October 7, 2026 04:42
0762bbe to
664ca20
Compare
Member
|
@davecheney I am using https://github.com/soypat/fat with some success |
Contributor
Author
|
@deadprogram thanks for the advice. Tinyfs works for my project at the moment so I’d like to land this fix, plus another that removes an allocation the readdir path, to follow the Boy Scout rule. |
deadprogram
approved these changes
Oct 13, 2026
deadprogram
left a comment
deadprogram
left a comment
Member
There was a problem hiding this comment.
Thank you for the correction @davecheney
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
An off-by-one error in the bit shifts and seconds mask caused timestamps to be incorrectly packed into the FAT timestamp structure. This caused files to report incorrect modification dates and times.