Conversation
jmgasper
marked this pull request as ready for review
September 15, 2026 08:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Email-change verification fails when the request reaches a different API instance from the one that issued the link. The old cache configuration uses
store, which@nestjs/cache-manager3 ignores, so pending changes stay in each instance's memory despite Redis being configured.Configure the global cache through a Redis-backed Keyv
storesentry. Keep millisecond TTLs, isolate keys under theidentity-api-v6namespace, and reject failed writes. Add integration coverage for a flow that crosses instances and completes after the issuing instance stops, plus replay rejection, expiration, deletion, and write failures. Document the shared-cache requirement and the active email-template configuration.Validation:
pnpm lintandpnpm buildpass.42bccf0; this change introduces no new failures.Pending email-change requests issued by the old in-memory cache must be restarted after rollout.
Production rollout completed on ECS task definition
identity-api-v6:25, image tagredis-cache-cf9ef84. All four API instances are healthy; the post-rollout check found no Redis cache read/write errors.