Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opportunities did not recognize Marathon Match
CANCELLEDresults, leaving superseded attempts without a useful test status and allowing placeholder or stale scores to display. Rows now show a neutral Cancelled label, select the newest result for each scoring phase, suppress cancelled phase scores and their legacy fallbacks, and exclude cancelled results from dashboard points.The change covers the existing shared helpers used by submission rows and history, with documentation in the Opportunities README. It recognizes both
CANCELLEDandCANCELEDaliases.Validation: Node 22.13.0,
yarn lint, andNODE_OPTIONS=--max-old-space-size=16384 yarn run buildpass. All 111 tests across the Marathon utilities, challenge detail flows, and submission history suites pass. Four new utility cases fail on unchangedorigin/dev(9d879b43d), and the row regression verifies the visible Cancelled label and unavailable score.Companion marathon-match-api-v6 PR #435 serializes member dispatch, persists cancellation before stopping the old scorer, and waits for shutdown before replacement. Community-app is outside the requested scope.