Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,7 @@
## 2024-05-18 - Avoid unnecessary array allocations in frequent I/O paths
**Learning:** `upsertSession` in `src/runtime/sessionStore.ts` is called very frequently (every time a session record is appended, which happens constantly during agent streaming). The original implementation used `.filter()` to remove the existing session and then pushed the updated one, resulting in significant garbage collection overhead and an O(N) array allocation on every single token/event stream chunk. Since this function is the bottleneck for chat interactivity, replacing `.filter()` with `.findIndex()` and in-place assignment yielded a > 2x speedup on session updates.
**Action:** When updating arrays that back frequent disk I/O operations (like the session store), always prefer in-place mutation and sorting over immutable array recreation (`.filter()`, `.map()`) to minimize garbage collection pauses.

## 2026-08-09 - Avoiding Chained Array Allocations in High-Frequency Math
**Learning:** In signal processing like `buildCandidate` (used heavily during stock discovery), chained array methods (`.map().slice().reduce()`) over hundreds of time-series data points cause rapid short-lived allocations, triggering GC pauses.
**Action:** Replace primitive array `.map()` allocations with source object arrays, and use in-place `for` loops indexed with `Math.max(0, len - N)` to emulate `.slice()` gracefully without allocations.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"better-sqlite3"
],
"overrides": {
"undici": ">=7.28.0 <8.0.0",
"undici": ">=7.29.0 <8.0.0",
"ws": ">=8.21.0"
}
},
Expand Down
14 changes: 7 additions & 7 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 29 additions & 17 deletions src/tools/discover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,14 @@ function pct(now: number, prev: number | undefined): number | null {
return ((now - prev) / prev) * 100;
}

function rsi14(closes: number[]): number | null {
if (closes.length < 15) return null;
const window = closes.slice(-15);
function rsi14(bars: readonly { close: number }[]): number | null {
const len = bars.length;
if (len < 15) return null;
let gains = 0;
let losses = 0;
for (let i = 1; i < window.length; i++) {
const d = window[i]! - window[i - 1]!;
const start = Math.max(0, len - 15);
for (let i = start + 1; i < len; i++) {
const d = bars[i]!.close - bars[i - 1]!.close;
if (d > 0) gains += d;
else losses -= d;
}
Expand All @@ -80,7 +81,8 @@ async function buildCandidate(ticker: string): Promise<Candidate> {
600,
() => getStockOhlcv(ticker, "1D", from, to),
).catch(() => [] as Awaited<ReturnType<typeof getStockOhlcv>>);
if (bars.length < 25) {
const len = bars.length;
if (len < 25) {
return {
ticker,
metric: null,
Expand All @@ -91,24 +93,34 @@ async function buildCandidate(ticker: string): Promise<Candidate> {
vol_ratio: null,
};
}
const closes = bars.map((b) => b.close);
const vols = bars.map((b) => b.volume);
const last = closes[closes.length - 1]!;
const prev1w = closes[closes.length - 6];
const prev1m = closes[closes.length - 22];
const recentVol = vols.slice(-5).reduce((a, b) => a + b, 0) / 5;
const priorVol =
vols.length >= 25
? vols.slice(-25, -5).reduce((a, b) => a + b, 0) / 20
: null;

// ⚡ Bolt: Removed .map() allocations for `closes` and `vols`, using original array directly.
const last = bars[len - 1]!.close;
const prev1w = bars[len - 6]?.close;
const prev1m = bars[len - 22]?.close;

// ⚡ Bolt: Replaced chained .slice().reduce() with in-place for loops
let recentVolSum = 0;
for (let i = Math.max(0, len - 5); i < len; i++) {
recentVolSum += bars[i]!.volume;
}
const recentVol = recentVolSum / 5;

let priorVolSum = 0;
for (let i = Math.max(0, len - 25); i < len - 5; i++) {
priorVolSum += bars[i]!.volume;
}
const priorVol = len >= 25 ? priorVolSum / 20 : null;

const volRatio = priorVol != null && priorVol > 0 ? recentVol / priorVol : null;

return {
ticker,
metric: null,
latest_close: last,
ret_1w: pct(last, prev1w),
ret_1m: pct(last, prev1m),
rsi14: rsi14(closes),
rsi14: rsi14(bars),
vol_ratio: volRatio,
};
}
Expand Down
Loading