Repository navigation
Conversation
… of discs
Calling hanoiTower({ numberOfDiscs: 0 }) (or a negative count) never
reached the numberOfDiscs === 1 base case and recursed until
"RangeError: Maximum call stack size exceeded". Guard the entry point:
with no discs to move the puzzle is already solved. Adds regression
tests for 0 and negative disc counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hanoiTower({ numberOfDiscs: 0 })(or any negative count) never reaches thenumberOfDiscs === 1base case and recurses untilRangeError: Maximum call stack size exceeded. With no discs to move, the puzzle is trivially already solved, so the function should simply do nothing (zero moves).Fix
Guard the public entry point of
hanoiTowerwith an early return fornumberOfDiscs <= 0. The recursion itself always calls with counts>= 1, so guarding the entry is sufficient. Algorithm behavior fornumberOfDiscs >= 1is untouched.Tests
Adds two regression tests to the existing suite (
0 discs→ no moves, no throw;-3 discs→ same).Verified before submitting (per CONTRIBUTING):
npm test— 589/589 pass (full suite)npm run lint— clean on touched fileshanoiTower.js— 100% statements / branches / functions / lines