chore: bump internal node to 22 and standardise#4084
Conversation
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughNode.js version references are updated from 20.20.2 to 22.23.1 across 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
8db9183 to
96977c9
Compare
The un-cast row.json() resolved to unknown (RowJSONType for JSONCompactEachRow), tripping TS18046 on rowData[i]. Matches the already-cast sibling stream loop.
96977c9 to
78460cd
Compare
Bumps the internal/toolchain Node version to the latest 22.x LTS (
22.23.1) and standardises it across the repo. Scope is the platform toolchain + the repo's own runtime images (all20 → 22upgrades, off the now-EOL node 20).Main changes
20.20.2 → 22.23.1across all CI workflows,.nvmrc,CONTRIBUTING.md, and the OSSdocker/Dockerfile(digest-pinned).@types/node → 22.20.0(root dep + pnpmoverrides, so the whole workspace resolves to it); lockfile regenerated.sdk-compatmatrix: adds Node 24 + 26 (keeps 20, still inengines).apps/coordinator→node:22.23.1-bookworm-slim;apps/docker-provider+apps/kubernetes-provider→node:22-alpine(reusing the exact digestapps/supervisoralready runs, so all four worker images are now identical). Stage aliases renamed offnode-20.Possible issues / test notes
@types/node22.x can surface new TS errors — typecheck (now on 22) is the gate.coordinator(crictl/CRI calls) and the docker/kubernetes providers (talking to their daemons) now run on node 22 (alpine/musl for the providers). Upgrade off EOL so low-risk, but it's deployed runtime code with its ownpublish-worker.ymlpipeline.