Skip to content

chore: bump internal node to 22 and standardise#4084

Open
carderne wants to merge 5 commits into
mainfrom
feature/tri-11472-bump-internal-node-version-to-22-and-standardise
Open

chore: bump internal node to 22 and standardise#4084
carderne wants to merge 5 commits into
mainfrom
feature/tri-11472-bump-internal-node-version-to-22-and-standardise

Conversation

@carderne

@carderne carderne commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Bumps the internal/toolchain Node version to the latest 22.x LTS (22.23.1) and standardises it across the repo. Scope is the platform toolchain + the repo's own runtime images (all 20 → 22 upgrades, off the now-EOL node 20).

Main changes

  • Node 20.20.2 → 22.23.1 across all CI workflows, .nvmrc, CONTRIBUTING.md, and the OSS docker/Dockerfile (digest-pinned).
  • @types/node → 22.20.0 (root dep + pnpm overrides, so the whole workspace resolves to it); lockfile regenerated.
  • sdk-compat matrix: adds Node 24 + 26 (keeps 20, still in engines).
  • App runtime images → node 22 (were on EOL node 20): apps/coordinatornode:22.23.1-bookworm-slim; apps/docker-provider + apps/kubernetes-providernode:22-alpine (reusing the exact digest apps/supervisor already runs, so all four worker images are now identical). Stage aliases renamed off node-20.

Possible issues / test notes

  • @types/node 22.x can surface new TS errors — typecheck (now on 22) is the gate.
  • Smoke-test the v3 worker pathcoordinator (crictl/CRI calls) and the docker/kubernetes providers (talking to their daemons) now run on node 22 (alpine/musl for the providers). Upgrade off EOL so low-risk, but it's deployed runtime code with its own publish-worker.yml pipeline.

@changeset-bot

changeset-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 78460cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Node.js version references are updated from 20.20.2 to 22.23.1 across .nvmrc, Docker, GitHub Actions workflows, package typings, and contributor documentation. The sdk-compat workflow matrix is also changed to use newer Node versions. Separately, ClickhouseClient.queryFast now casts row.json() to any[] before column hydration.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is detailed, but it does not follow the required template and omits Closes #issue, checklist items, testing, changelog, and screenshots. Add the template sections: Closes #issue, ✅ Checklist, Testing, Changelog, and Screenshots, or mark any intentionally N/A items clearly.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: standardizing the repo's Node version to 22 across tooling and workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/tri-11472-bump-internal-node-version-to-22-and-standardise

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@carderne carderne marked this pull request as ready for review June 30, 2026 14:00
coderabbitai[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new

pkg-pr-new Bot commented Jun 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@78460cd

trigger.dev

npm i https://pkg.pr.new/trigger.dev@78460cd

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@78460cd

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@78460cd

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@78460cd

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@78460cd

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@78460cd

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@78460cd

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@78460cd

commit: 78460cd

devin-ai-integration[bot]

This comment was marked as resolved.

@carderne carderne force-pushed the feature/tri-11472-bump-internal-node-version-to-22-and-standardise branch 2 times, most recently from 8db9183 to 96977c9 Compare June 30, 2026 15:47
carderne added 5 commits June 30, 2026 18:00
The un-cast row.json() resolved to unknown (RowJSONType for
JSONCompactEachRow), tripping TS18046 on rowData[i]. Matches the
already-cast sibling stream loop.
@carderne carderne force-pushed the feature/tri-11472-bump-internal-node-version-to-22-and-standardise branch from 96977c9 to 78460cd Compare June 30, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant