Skip to content

refactor(webapp): remove redundant React fragments - #4691

Merged
carderne merged 1 commit into
perf/webapp-stable-component-identities-tri-13381from
refactor/webapp-redundant-fragments-tri-13381
Aug 19, 2026
Merged

refactor(webapp): remove redundant React fragments#4691
carderne merged 1 commit into
perf/webapp-stable-component-identities-tri-13381from
refactor/webapp-redundant-fragments-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Remove redundant React fragments from the dashboard and enforce react/jsx-no-useless-fragment.

The cleanup returns existing nodes, arrays, and empty states directly without adding wrapper elements.

Base: #4689

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 75761faa-4e88-469f-a316-ac5430d206b5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4c4e216

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@carderne
carderne marked this pull request as ready for review August 19, 2026 11:23
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the refactor/webapp-redundant-fragments-tri-13381 branch 2 times, most recently from 3b6a0f8 to ae18fe6 Compare August 19, 2026 11:49
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the refactor/webapp-redundant-fragments-tri-13381 branch from ae18fe6 to 4c4e216 Compare August 19, 2026 14:54
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@4c4e216

trigger.dev

npm i https://pkg.pr.new/trigger.dev@4c4e216

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@4c4e216

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@4c4e216

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@4c4e216

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@4c4e216

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@4c4e216

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@4c4e216

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@4c4e216

commit: 4c4e216

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

Open in Devin Review

Comment thread .oxlintrc.json
@carderne
carderne merged commit a7a1e74 into main Aug 19, 2026
42 checks passed
@carderne
carderne deleted the refactor/webapp-redundant-fragments-tri-13381 branch August 19, 2026 15:36
carderne added a commit that referenced this pull request Aug 19, 2026
## Summary

Add explicit types to native dashboard buttons and enforce
`react/button-has-type`.

This prevents action buttons from accidentally submitting a surrounding
form. Shared button primitives retain their caller-selected submit and
reset semantics with documented lint exceptions.

Base: [#4691](#4691)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants