Skip to content

fix(webapp): align tree mouse and keyboard interactions - #4701

Merged
carderne merged 5 commits into
fix/webapp-selectable-row-semantics-tri-13381from
fix/webapp-tree-interactions-tri-13381
Aug 19, 2026
Merged

fix(webapp): align tree mouse and keyboard interactions#4701
carderne merged 5 commits into
fix/webapp-selectable-row-semantics-tri-13381from
fix/webapp-tree-interactions-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Move tree selection onto semantic tree items and use native expansion buttons.

Dashboard and story tree rows now share mouse and keyboard selection through getNodeProps. Expand and collapse affordances are named buttons instead of clickable layout elements.

Base: #4700

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5cce769

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0836c64f-fda5-4cae-ad18-0fe9fb516dc5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne
carderne force-pushed the fix/webapp-tree-interactions-tri-13381 branch from f91b2b6 to 98f0718 Compare August 19, 2026 11:01
@carderne
carderne marked this pull request as ready for review August 19, 2026 11:23
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the fix/webapp-tree-interactions-tri-13381 branch from 98f0718 to 0c04fad Compare August 19, 2026 11:48
@carderne
carderne force-pushed the fix/webapp-tree-interactions-tri-13381 branch 2 times, most recently from 01dd835 to fb368fe Compare August 19, 2026 11:50
@carderne
carderne force-pushed the fix/webapp-tree-interactions-tri-13381 branch from fb368fe to 9aa9cbb Compare August 19, 2026 11:55
@carderne
carderne force-pushed the fix/webapp-tree-interactions-tri-13381 branch 2 times, most recently from 8797fd4 to a3d702a Compare August 19, 2026 11:58
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the fix/webapp-tree-interactions-tri-13381 branch 2 times, most recently from 2877bf2 to 3abdf38 Compare August 19, 2026 13:07
@carderne
carderne force-pushed the fix/webapp-tree-interactions-tri-13381 branch from 3abdf38 to e4ebd46 Compare August 19, 2026 13:09
@carderne
carderne force-pushed the fix/webapp-tree-interactions-tri-13381 branch 2 times, most recently from 2936415 to beb6bc5 Compare August 19, 2026 13:38
@carderne
carderne force-pushed the fix/webapp-tree-interactions-tri-13381 branch from beb6bc5 to 4779d56 Compare August 19, 2026 14:04
The task-arrow button used a disabled attribute for leaf rows, which
also blocks the click event entirely, so alt-clicking a leaf's arrow
no longer expanded or collapsed every row at that depth. Guard the
per-node toggle instead and keep the button clickable, and mark it
aria-disabled for styling. Also pass preventScroll to the post-toggle
focus() call so it can't fight the just-completed scrollToNode.
@carderne
carderne force-pushed the fix/webapp-tree-interactions-tri-13381 branch from 4779d56 to b439186 Compare August 19, 2026 14:54
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@b439186

trigger.dev

npm i https://pkg.pr.new/trigger.dev@b439186

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@b439186

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@b439186

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@b439186

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@b439186

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@b439186

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@b439186

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@b439186

commit: b439186

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne merged commit 5e50d2f into main Aug 19, 2026
37 checks passed
@carderne
carderne deleted the fix/webapp-tree-interactions-tri-13381 branch August 19, 2026 15:36
carderne added a commit that referenced this pull request Aug 19, 2026
## Summary

Enable keyboard-event and static-element interaction safeguards across
the dashboard.

Earlier stack changes move actionable behavior to native controls. This
final enforcement keeps narrowly documented exceptions for focus
forwarding, scoped Escape handling, CodeMirror focus, and pointer-driven
table column resizing.

`jsx-a11y/no-autofocus` remains disabled.

Base: [#4701](#4701)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants