fix(clickhouse): use compatible logs text index syntax - #4704
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (21)
🧰 Additional context used📓 Path-based instructions (1)internal-packages/clickhouse/schema/[0-9][0-9][0-9]_*.sql📄 CodeRabbit inference engine (internal-packages/clickhouse/CLAUDE.md)
Files:
🔇 Additional comments (2)
WalkthroughThe ClickHouse 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Allow the logs search schema migration to run on ClickHouse versions that require text index options to be literals.
Root cause
The text index declared
lowerUTF8(search_text)as a preprocessor option. Some ClickHouse versions reject that column expression while parsing index settings. The projectedsearch_textis already normalized to lowercase before insertion, so removing the redundant preprocessor preserves search behavior.Verified with the task events search integration tests.