Skip to content

perf(ci): speed up webapp test execution - #4709

Open
carderne wants to merge 14 commits into
mainfrom
perf/rebalance-webapp-ci-shards
Open

perf(ci): speed up webapp test execution#4709
carderne wants to merge 14 commits into
mainfrom
perf/rebalance-webapp-ci-shards

Conversation

@carderne

@carderne carderne commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Speeds up webapp test jobs by balancing measured work across runners, reducing repeated container setup, and ensuring test workers release shutdown resources promptly. Unit tests run across 24 duration-aware shards, while E2E tests run across two balanced shards.

Design

RunEngine shutdown now closes processing resources before support resources, continues cleanup if one close fails, and reuses one shutdown promise for concurrent callers. Redis workers clear completed shutdown deadlines so finished tests no longer wait on idle timers.

Container-heavy suites are split only where it improves parallelism, and repeated replication and engine fixtures are consolidated where one end-to-end case provides coverage. Timing weights are refreshed for all affected files.

Dependency installation overlaps container pulls, and both workflows use WarpBuild's Node setup action.

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9096816

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The webapp workflows now use the pinned Node setup action, concurrent dependency installation and Docker image pulls, expanded sharding, and duration-based E2E sequencing. Test coverage was added or reorganized for run-list read-through, dashboard-agent watches, environment concurrency limits, external deployment handling, and shutdown behavior. RunEngine shutdown is memoized, and Redis worker shutdown clears its deadline timer. The test timing map was regenerated.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the main changes but omits the required issue, checklist, testing, changelog, and screenshots sections. Add the required template sections, complete the checklist, document testing steps, provide a changelog entry, and include screenshots or state that they are not applicable.
Docstring Coverage ⚠️ Warning Docstring coverage is 20.45% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: improving webapp test execution speed in CI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/rebalance-webapp-ci-shards

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@carderne
carderne marked this pull request as ready for review August 19, 2026 15:30

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@carderne carderne changed the title perf(ci): rebalance webapp test shards perf(ci): speed up webapp test execution Aug 19, 2026
github-advanced-security[bot]

This comment was marked as resolved.

@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@b9f314e

trigger.dev

npm i https://pkg.pr.new/trigger.dev@b9f314e

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@b9f314e

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@b9f314e

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@b9f314e

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@b9f314e

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@b9f314e

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@b9f314e

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@b9f314e

commit: b9f314e

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment thread apps/webapp/test/helpers/apiRunListPresenterTestHelpers.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants