Skip to content

chore(webapp): scope memo dependency diagnostics #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carderne merged 1 commit into from
Aug 20, 2026
Merged

chore(webapp): scope memo dependency diagnostics #4721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/webapp/app/components/dashboard-agent/DashboardAgentPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export function DashboardAgentPanel({
toast.error("We couldn't load your previous chats. Try again in a moment.");
}
}),
[actionPath, organization.id, toast]
[actionPath, organization.id, toast, justRead, visibleChatId]
);

// Bumped on each open so a slower earlier open can't overwrite a newer one.
Expand Down
4 changes: 4 additions & 0 deletions apps/webapp/app/components/navigation/SideMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,7 @@ export function SideMenu({
}, []);

// Animate width + progress over COLLAPSE_ANIM_MS (toggle button, ⌘B shortcut, release-snap).
/* oxlint-disable react/react-compiler -- The animation step is local to each callback invocation. */
const animateTo = useCallback(
(targetWidth: number, targetProgress: number) => {
if (rafRef.current !== null) cancelAnimationFrame(rafRef.current);
Expand Down Expand Up @@ -619,6 +620,7 @@ export function SideMenu({
},
[writeVisual]
);
/* oxlint-enable react/react-compiler */

// Collapse/expand to a resting state and remember it.
const applyCollapsed = useCallback(
Expand All @@ -637,6 +639,7 @@ export function SideMenu({

// Drag runs on window-level listeners so releasing anywhere finalizes it. (Pointer capture alone
// was unreliable: if the browser drops it mid-drag, the release never fires and the menu strands.)
/* oxlint-disable react/react-compiler -- Drag handlers share invocation-local state and listeners. */
const onHandlePointerDown = useCallback(
(e: ReactPointerEvent<HTMLDivElement>) => {
if (e.button !== 0) return;
Expand Down Expand Up @@ -746,6 +749,7 @@ export function SideMenu({
},
[animateTo, applyCollapsed, persistSideMenuPreferences, writeVisual]
);
/* oxlint-enable react/react-compiler */

// Keep the drag handlers' collapsed mirror in sync; tear down any in-flight animation/drag on unmount.
useEffect(() => {
Expand Down
2 changes: 2 additions & 0 deletions ...s.$organizationSlug.projects.$projectParam.env.$envParam.playground.$agentParam/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,7 @@ function PlaygroundChat() {

const session = transport.getSession(chatId);

/* oxlint-disable react/react-compiler -- The transport and chat ID are stable for this component's lifetime. */
const handlePreload = useCallback(async () => {
setPreloading(true);
try {
Expand All @@ -403,6 +404,7 @@ function PlaygroundChat() {
setPreloading(false);
}
}, [transport, chatId]);
/* oxlint-enable react/react-compiler */

const handleNewConversation = useCallback(() => {
// Navigate without ?conversation= so the loader returns activeConversation=null
Expand Down
2 changes: 2 additions & 0 deletions apps/webapp/app/routes/resources.metric.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ export function MetricWidget({
},
});

/* oxlint-disable react/react-compiler -- These ref objects are stable callback inputs. */
const submit = useCallback(() => {
if (!isVisibleRef.current) {
isDirtyRef.current = true;
Expand Down Expand Up @@ -263,6 +264,7 @@ export function MetricWidget({
}
});
}, [isVisibleRef]);
/* oxlint-enable react/react-compiler */
submitRef.current = submit;

// Clean up on unmount
Expand Down