chore(webapp): scope route effect synchronization - #4728
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (actionData?.ok && actionData.action === "create") { | ||
| // oxlint-disable-next-line react/react-compiler -- This effect intentionally synchronizes route state after an external or lifecycle change. |
There was a problem hiding this comment.
🔍 Suppressed rule react/react-compiler is not configured anywhere, so the directives are inert
.oxlintrc.json enables the react plugin but never configures a react-compiler rule, and no other config in the repo references it (searched *.json/*.js/*.mjs/*.yml). The lint script is plain oxlint with no unused-directive reporting, so these // oxlint-disable-next-line react/react-compiler comments neither suppress anything today nor cause a lint error. They match a pre-existing convention already present in base (e.g. apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.team/route.tsx:973), so this is consistent — but worth confirming that the intended rule/plugin will actually be enabled, otherwise the annotations are documentation only.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
Scopes React Compiler diagnostics for route effects that intentionally synchronize loader data, navigation, submissions, polling, streams, and transient UI state. Each suppression remains attached to the reported synchronization call.