chore(webapp): enforce React Compiler lint - #4732
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "react/button-has-type": "error", | ||
| "react/jsx-no-useless-fragment": "error", | ||
| "react/no-unstable-nested-components": "error", | ||
| "react/react-compiler": "error", |
There was a problem hiding this comment.
🔍 Enabling react/react-compiler only for apps/webapp/app; no local verification possible
The rule is enabled as error in the webapp override block, so any existing React Compiler violation across apps/webapp/app/**/*.{ts,tsx} will fail CI's code-quality job. I could not run oxlint in this environment (no installed toolchain), so the assumption that the whole webapp is already compiler-clean is unverified — worth confirming CI is green before merge. Note packages/react-hooks is deliberately left without this rule, which is an intentional scope choice but means hook code shipped to users isn't checked.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Enforces
react/react-compileras an error for the webapp now that all reported compiler diagnostics are fixed or narrowly scoped. Removes the unused lazy-ref helper made obsolete by the ref initialization cleanup.