Replace Reboot trait with Data struct and release v0.4.0 - #12
Merged
Merged
Conversation
On the lpc55, the reboot must be triggered from the idle task so the reboot function needs to return to yield back.
This simplifies the type signature for App and also makes it possible to make some functions optional.
This feature is only available on some hardware variants. If it is not enabled, the command will return an error and normal reboot to firmware update can still be used.
This was referenced Sep 16, 2026
daringer
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
Reboot::reboot_to_firmware_updatenon-diverging, introduces aDatastruct to make the constructor arguments simpler, replaces theReboottrait with function pointers in this struct, makes destructive firmware update optional and releases v0.4.0 with these changes.