[pull] master from php:master - #1214
Merged
Merged
Conversation
php_session_send_cookie() discarded the result of sapi_add_header_ex() and always returned SUCCESS. When the SAPI refuses a Set-Cookie header carrying CR or LF, the warning it emits can reach a userland error handler that calls session_destroy(), and php_session_reset_id() then appends the released PS(id). Return what sapi_add_header_ex() reports so the caller stops before touching session state again. Closes GH-22923
* PHP-8.4: ext/session: report a rejected session cookie header
* PHP-8.5: ext/session: report a rejected session cookie header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )