fix(channel): bind NOTIFY payloads via pg_notify - #1365
Open
arimu1 wants to merge 1 commit into
Open
Conversation
arimu1
force-pushed
the
fix/1339-channel-notify-escape
branch
from
September 13, 2026 00:38
6459faa to
c08e3b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Channel.fromNameAndProtocolby sending notification payloads through bound parameters instead of embedding them in the SQL string.NOTIFY ... $1syntax; useSELECT pg_notify($1, $2) IS NULLwith both channel name and payload bound astext.executeSizedso the extended query completes withSyncand notifications are delivered reliably to listeners on the same session.Fixes #1339
Test plan
ChannelTestcase with a payload containing single quotes and a double quote; verified round-trip locally against Postgres 11 (docker) on port 15432.testsJVM/testOnly tests.ChannelTest) with projectdocker composePostgres.