Define machines with typed targets and registered programs - #211
Merged
Conversation
Contributor
Type performanceMeasured with TypeScript 6.0.3 and
Marginal instantiations are measured against the matching setup without that API call:
Check times (informational)
Type instantiations are the comparison metric. Check time varies with runner load and is informational only. |
Contributor
Runtime performanceMedian of 5 independent benchmark processes on Pull request baseline
Process runtime reference points
Effect Machine change from base
Process runtime reference change from base
Regression guardNo large, noise-adjusted throughput or heap regressions detected. Versions and interpretation
Higher throughput is better; lower heap is better. Variability is the median absolute deviation across independent processes, relative to their median. Small differences on shared GitHub-hosted hardware remain informational; the required guard rejects only large changes beyond the measured noise allowance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Machine.targets(Root)references. Retained data usesupdate; named branch groups bind exact constructors for conditional selection, nested construction, and queued commands without duplicating destination paths.Machine.make. Source types determine required inputs, reachable outcome handlers, and used Effect services. Lazy Effect and Stream values can be passed directly.Changeset
Minor changeset for the four packages in the fixed release group, with direct migration guidance.
Validation
pnpm check— includes 732 core runtime tests, 1,141 core/React type assertions, architecture and installed-package checksLocal
pnpm perf:typesandpnpm perf:runtimepassed. Editor-completion checks cover handler fields, event names, invocations, and selected constructors. A forced generic-versus-optimized regression test verifies retained callback contexts across root updates, inline transitions, and named branches.Runtime fixtures use native value constructors in both versions; a compatibility test verifies that the adapter forwards the same constructor directly. Performance limits are unchanged.
Reviewed the hosted type comparison: most scenarios improve, including ordinary handlers, named branches, invocation, and composition. The largest increase is 6.4% for three independent implementations, within the existing instantiation limits.
Reviewed the hosted runtime and memory comparison: five paired runs pass the unchanged regression guard. Flat throughput is close to the base and heap usage is stable; some hierarchical scenarios remain up to 7.5% slower.