You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds a few symbols composed of stacked tildes and horizontal lines. I explain the reasoning for each change below.
tilde.double makes sense in my opinion as a non-semantic variant of approx. I have chosen to only include the .not variant but I am open to including .eq, .equiv, and .hat as well. I am also open to excluding tilde.double from this PR if we are unable to reach a consensus.
The rename from minus.tilde to eq.tilde is consistent with the existing tilde.eq, as well as the Unicode character being a Relation, not a Binary, even though its name uses "MINUS" instead of "EQUAL". Same for tilde.eq.tilde.
equiv.tilde is consistent with the existing tilde.equiv.
approx.equiv is consistent with other uses of .equiv, such as in tilde.equiv.
I mean that tilde.tilde.eq would be the actual problem, since you'd expect that to be ≊, but it's actually equivalent to tilde.eq.tilde, which would be ⩬.
And I take this as reason enough to throw out tilde.tilde altogether, tho now that I think about it there might be a case for having justtilde.tilde with no other modifiers.
Oh, right, there's that as well. Even worse then, since adding tilde.eq.tilde would add tilde.tilde as fallback for it, so then you don't even get an error if you misremember tilde.double as tilde.tilde.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breakingThis involves a breaking changewaiting on reviewsBreaking and non-breaking changes need respectively 3 and 2 reviews
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few symbols composed of stacked tildes and horizontal lines. I explain the reasoning for each change below.
tilde.doublemakes sense in my opinion as a non-semantic variant ofapprox. I have chosen to only include the.notvariant but I am open to including.eq,.equiv, and.hatas well. I am also open to excludingtilde.doublefrom this PR if we are unable to reach a consensus.The rename from
minus.tildetoeq.tildeis consistent with the existingtilde.eq, as well as the Unicode character being a Relation, not a Binary, even though its name uses "MINUS" instead of "EQUAL". Same fortilde.eq.tilde.equiv.tildeis consistent with the existingtilde.equiv.approx.equivis consistent with other uses of.equiv, such as intilde.equiv.