feat(speculation): add prioritizer + prioritization-limit extensions#320
Open
behinddwalls wants to merge 1 commit into
Open
feat(speculation): add prioritizer + prioritization-limit extensions#320behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
This was referenced Jul 8, 2026
behinddwalls
force-pushed
the
preetam/ext/speculation-selector
branch
from
0ab1871 to
d9084c2
Compare
behinddwalls
force-pushed
the
preetam/ext/speculation-prioritizer
branch
from
844dbfc to
ade23bb
Compare
Add the prioritizer seam and its limit counterpart from the speculation RFC, as vendor-agnostic extension interfaces under submitqueue/extension/speculation/. prioritizer: the queue-wide policy that rations a shared build budget across every in-flight batch. The controller hands it the queue's candidate paths — every path that is Selected (wants a slot) or Prioritized/Building (holds a slot), each with its score — and it returns sparse decisions: Promote to admit a pending path, Cancel to preempt a running one; omitted paths are left as-is. Whether it preempts is its own per-queue policy (sticky-slots vs preemptive), so the interface is unchanged either way. It never writes; the controller maps each decision to a guarded status transition (Promote → Prioritized, Cancel → Cancelling) and enacts it, staying the single writer. It shares the selector's SpeculationPathDecision output and ranks on the scorer's path Score, so it lives in the same speculation/ family. prioritizationlimit: the "how much" policy bounding how many builds the queue runs at once — the queue's concurrent-build budget and the ultimate cap on speculation's demand on CI. Injected into the prioritizer at construction and called by it; the value is dynamic, not a fixed constant. Each follows the repo extension contract: Factory.For(Config) (T, error) with Config carrying only QueueName. Includes READMEs, gomock packages, and programmable fakes. Interfaces only; concrete impls and controller wiring are deferred.
behinddwalls
force-pushed
the
preetam/ext/speculation-selector
branch
from
d9084c2 to
0ae2849
Compare
behinddwalls
force-pushed
the
preetam/ext/speculation-prioritizer
branch
from
ade23bb to
2516cc1
Compare
behinddwalls
added a commit
that referenced
this pull request
Jul 9, 2026
## Summary
Reshape the speculation tree data model around the Base/Head path that
the build stage actually consumes, and align its store with the
speculation design.
entity: SpeculationPath{Base, Head} becomes the unit;
SpeculationPathInfo carries the path plus its Score, controller-owned
Status
(candidate/selected/prioritized/building/passed/failed/cancelling/cancelled),
and BuildID — Path is immutable once persisted, Score/Status/BuildID are
updateable by the controller. Score is scorer-computed and
controller-persisted dynamic state — recomputed on every respeculate,
not set at enumeration. Selected/Prioritized and Cancelling/Cancelled
split desire vs budget-cleared and cancel-intent vs terminal, so the
persisted status carries the cross-stage contract. Adds
SpeculationPathAction (Promote/Cancel) and SpeculationPathDecision for
the selector and prioritizer seams. SpeculationTree.Speculations becomes
Paths, and the tree gains a Version for optimistic locking (starts at 1,
incremented per change). The Build entity uses the shared
SpeculationPath (Head = the batch under verification) and drops its own
Score, which was never populated or read.
storage: SpeculationTreeStore.UpdateSpeculations(batchID,
[]SpeculationInfo) becomes a pure conditional write — Update(ctx,
batchID, oldVersion, newVersion, paths) — returning ErrVersionMismatch
when the persisted version does not match, per the repo's
optimistic-locking pattern (version arithmetic owned by the controller).
The MySQL impl treats rowsAffected == 1 as success, 0 as version
mismatch, and anything else as a generic error. The MySQL column
speculations is renamed paths and the schema gains a version column.
MySQL impl, mock, and storage integration coverage (create/get
round-trip, duplicate, versioned whole-tree overwrite, stale-write
rejection, not-found) added/updated.
## Test Plan
## Issues
## Stack
1. @ #231
1. #315
1. #316
1. #317
1. #320
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the prioritizer seam and its limit counterpart from the speculation RFC, as vendor-agnostic extension interfaces under submitqueue/extension/speculation/.
prioritizer: the queue-wide policy that rations a shared build budget across every in-flight batch. The controller hands it the queue's candidate paths — every path that is Selected (wants a slot) or Prioritized/Building (holds a slot), each with its score — and it returns sparse decisions: Promote to admit a pending path, Cancel to preempt a running one; omitted paths are left as-is. Whether it preempts is its own per-queue policy (sticky-slots vs preemptive), so the interface is unchanged either way. It never writes; the controller maps each decision to a guarded status transition (Promote → Prioritized, Cancel → Cancelling) and enacts it, staying the single writer. It shares the selector's SpeculationPathDecision output and ranks on the scorer's path Score, so it lives in the same speculation/ family.
prioritizationlimit: the "how much" policy bounding how many builds the queue runs at once — the queue's concurrent-build budget and the ultimate cap on speculation's demand on CI. Injected into the prioritizer at construction and called by it; the value is dynamic, not a fixed constant.
Each follows the repo extension contract: Factory.For(Config) (T, error) with Config carrying only QueueName. Includes READMEs, gomock packages, and programmable fakes. Interfaces only; concrete impls and controller wiring are deferred.
Test Plan
Issues
Stack