[draft / wip] feat(stovepipe): coalesce backlog in process controller (PR A)#324
Draft
mnoah1 wants to merge 1 commit into
Draft
[draft / wip] feat(stovepipe): coalesce backlog in process controller (PR A)#324mnoah1 wants to merge 1 commit into
mnoah1 wants to merge 1 commit into
Conversation
Compare accepted requests against queue.latest_request_id and mark older heads superseded. Latest heads remain accepted until admit lands in a follow-up PR.
65c5fd6 to
0bb81c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR A — process coalesce only. Touches
stovepipe/controller/process/(3 files).accepted→ compare againstqueue.latest_request_id; older heads →superseded; latest → ack (admit deferred)superseded/processing→ ack no-op (processingrepublish in PR C)No proto, service wiring, or registry changes in this PR.
Why
Ingest admits every distinct head, but only the latest is worth validating. This PR drops intermediates before admit, gate, and build strategy land — kept isolated to one package for review.
Follow-up stack
mnoah1/stovepipe-process-coalescemnoah1/stovepipe-build-contractBuildRequestproto/topicmnoah1/stovepipe-process-republishprocessing→ build republish + registryBatchSize=1on process subscriptionSaved WIP for B/C at local branch
mnoah1/stovepipe-process-republish-wip(65c5fd6).Test plan
//stovepipe/controller/process:go_default_test//stovepipe/controller:go_default_test//test/integration/stovepipe:go_default_test