Skip to content

feat(stovepipe): add request log table - #645

Merged
mnoah1 merged 2 commits into
mnoah1/stovepipe-request-history-protofrom
mnoah1/stovepipe-request-history-storage
Sep 1, 2026
Merged

feat(stovepipe): add request log table#645
mnoah1 merged 2 commits into
mnoah1/stovepipe-request-history-protofrom
mnoah1/stovepipe-request-history-storage

Conversation

@mnoah1

@mnoah1 mnoah1 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Intent:

Changes:

  • Add an append-only MySQL request_log table with stable occurrence identity.
  • Keep core lifecycle values in columns and store occurrence-specific context in a non-null JSON metadata column.
  • Require writers to supply every non-null column value; the table defines no value defaults.
  • Remove dedicated superseding-request, build-ID, and fact-degree columns.
  • Index records for bounded, complete per-request reads.
  • Include request-log data in integration database cleanup.

Test Plan

  • Loaded all Stovepipe schemas into an isolated MySQL 8 database.
  • Inserted representative request-log records and exercised chronological retrieval.
  • ./tool/bazel test //stovepipe/extension/storage/mysql/...
  • make lint check-tidy check-gazelle

Revert Plan

Revert this PR and remove the unused table before deploying code that writes request-log records.

Jira Issues

None.

@mnoah1
mnoah1 marked this pull request as ready for review August 27, 2026 16:55
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners August 27, 2026 16:55
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-storage branch from b384332 to 7727366 Compare August 31, 2026 16:28
@mnoah1 mnoah1 changed the title feat(stovepipe): add request history table feat(stovepipe): add request log table Aug 31, 2026
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-storage branch from 7727366 to cb5d781 Compare August 31, 2026 16:50
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-storage branch 3 times, most recently from cad590d to ebb7b56 Compare August 31, 2026 22:21
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-storage branch from ebb7b56 to 9933a99 Compare August 31, 2026 22:38
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-storage branch from 9933a99 to 9d4815a Compare August 31, 2026 22:52
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-storage branch from 9d4815a to 8433f10 Compare August 31, 2026 23:03
Comment thread stovepipe/extension/storage/mysql/schema/request_log.sql Outdated
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-storage branch from 8433f10 to 2d019cb Compare September 1, 2026 15:00
@mnoah1
mnoah1 added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit 12a81c0 Sep 1, 2026
15 checks passed
@mnoah1
mnoah1 deployed to stack-rebase September 1, 2026 15:13 — with GitHub Actions Active
@behinddwalls
behinddwalls deleted the mnoah1/stovepipe-request-history-storage branch September 1, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants